Skip to content

Bug Fix: Needs to patch v10_06_00_01 Fixes Off-beam Normalization #544

Merged
kjplows merged 2 commits intodevelopfrom
feature/zennamo_fixoffbeam_springprod
Jul 18, 2025
Merged

Bug Fix: Needs to patch v10_06_00_01 Fixes Off-beam Normalization #544
kjplows merged 2 commits intodevelopfrom
feature/zennamo_fixoffbeam_springprod

Conversation

@jzennamo
Copy link
Copy Markdown
Contributor

@jzennamo jzennamo commented Jul 2, 2025

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@jzennamo jzennamo self-assigned this Jul 2, 2025
@jzennamo jzennamo added the bug Something isn't working label Jul 2, 2025
Copy link
Copy Markdown
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I object the font you used for the ampersand.

@kjplows
Copy link
Copy Markdown
Contributor

kjplows commented Jul 7, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this to Testing in SBN software development Jul 7, 2025
@kjplows
Copy link
Copy Markdown
Contributor

kjplows commented Jul 15, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows
Copy link
Copy Markdown
Contributor

kjplows commented Jul 15, 2025

given #543 passed CI tests and this is one character, and I see SBND CI tests pass, I am happy to consider this PR OK.

@kjplows kjplows moved this from Testing to To merge in SBN software development Jul 15, 2025
@kjplows kjplows merged commit eae1728 into develop Jul 18, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Jul 18, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Jul 18, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Jul 30, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the v10_06_00_02 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

4 participants