CRT Channel Status #641

henrylay97 · 2025-02-17T10:56:45Z

Description

This adds to the CRT calibration service with a list of bad channels. Like the pedestals and timing offsets these are filled from a text file. The service then denotes the channels (and their paired channel) with the correct labels using the enumeration provided in SBNSoftware/sbnobj#119. Only bad channels are specified - the default value is good (0).

The status is then used to skip over bad channels in the first stage of the CRT reconstruction. (It is also used in an Analyzer used for CRT calibrations which will soon be provided in a separate PR).

The PR will remain a draft until after this week's CRT meeting where a decision on the two channels labelled as quiet (3) will be made.

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?

Relevant PR links (optional)

Requires the merging of SBNSoftware/sbnobj#119

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=39940

kjplows · 2025-02-17T11:49:15Z

sbndcode/Calibration/CRT/CalibService/SBNDCRTBadChannels_v1.txt

Picky comment, but if the enum changes in sbnobj/SBND/CRT/CRTEnums.h this status could break - would it be clearer to replace e.g.

182 30 1

with

182 30 kDeadChannel

?

kjplows · 2025-02-17T11:50:44Z

sbndcode/CRT/CRTReco/CRTStripHitProducer_module.cc

Leaving a comment here to pick up on after Wednesday's CRT meeting.
If we decide to keep quiet channels this will need to change

Since we decided to keep the quiet channels, I'm requesting a change here. Thanks Henry!

henrylay97 · 2025-02-18T10:19:28Z

Great suggestions from John. I have removed all implicit conversions so that the enum is used properly. Will still wait to make a decision on the quiet channels before "un-drafting".

kjplows · 2025-02-21T00:19:55Z

sbndcode/CRT/CRTReco/CRTStripHitProducer_module.cc

Since we decided to keep the quiet channels, I'm requesting a change here. Thanks Henry!

sbndcode/CRT/CRTReco/CRTStripHitProducer_module.cc

henrylay97 · 2025-02-24T10:12:51Z

No disagreements in the CRT channel after follow up from Wednesday's meeting. Have implemented the required change. Only need to check on kDeadChannel not kDeadNeighbourChannel as the latter is only ever assigned as a pair to the former.

kjplows · 2025-02-24T11:10:34Z

Looks good, thanks Henry!

bear-is-asleep · 2025-03-03T19:40:28Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_04 SBNSoftware/sbncode@v10_04_04

FNALbuild · 2025-03-03T20:02:06Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-03-03T20:04:11Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-03-03T20:10:12Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-03-03T20:22:53Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

bear-is-asleep · 2025-03-04T17:02:53Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03

FNALbuild · 2025-03-04T17:24:02Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-03-04T17:31:22Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-03-04T17:41:36Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-03-04T18:09:02Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

bear-is-asleep · 2025-03-04T20:35:03Z

Approved

kjplows · 2025-03-07T17:09:03Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_05 SBNSoftware/sbnanaobj@v10_00_00 SBNSoftware/sbnobj@v10_00_05 SBNSoftware/sbncode@v10_04_04

FNALbuild · 2025-03-07T17:20:42Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-03-07T17:22:17Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-03-07T17:30:09Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-03-07T17:43:01Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

henrylay97 · 2025-03-10T08:51:41Z

@RachelCoackley @bear-is-asleep do we understand these product differences? The true particle stuff in the CAF tests. They aren't related to this PR and they seem to be appearing in lots of PR tests?

RachelCoackley · 2025-03-10T09:55:59Z

@henrylay97 @bear-is-asleep I'm not too sure what these CAF differences are, but as a guess are they related to this merged PR in sbnanaobj

RachelCoackley · 2025-03-10T10:23:52Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

I can't see these caf differences in this trigger of the CI where v09_23_03 of sbnanaobj was used (which was the version used when creating the current ref files). Looks like the PR I linked above was added between v09_23_03 and v10_00_00 of sbnanaobj: SBNSoftware/sbnanaobj@v09_23_03...v10_00_00. We can update ref files to reflect this change when a new version of sbndcode comes out (and then those differences shouldn't appear anymore 🤞)

kjplows · 2025-03-10T11:13:39Z

Hi all, I've just checked the phase logs for nucosmics and can see the following:

4107: Checking record 0
4108:   rec.slc[0].reco.pfp[2].shw.producer differs: 9999999 vs 0
4109:   rec.slc[0].reco.pfp[2].shw.truth.p.end_process differs: 63 vs 1024
4110:   rec.slc[0].reco.pfp[2].shw.truth.p.start_process differs: 63 vs 1024
4111:   rec.slc[0].reco.pfp[2].trk.bestplane differs: -1 vs 1
4112:   rec.slc[0].reco.pfp[2].trk.truth.p.end_process differs: 63 vs 1024
4113:   rec.slc[0].reco.pfp[2].trk.truth.p.start_process differs: 63 vs 1024
4114:   rec.slc[1].reco.pfp[5].shw.producer differs: 9999999 vs 0
4115:   rec.slc[1].reco.pfp[5].shw.truth.p.end_process differs: 63 vs 1024
4116:   rec.slc[1].reco.pfp[5].shw.truth.p.start_process differs: 63 vs 1024
4117:   rec.slc[1].reco.pfp[5].trk.bestplane differs: -1 vs 0
4118:   rec.slc[1].reco.pfp[5].trk.truth.p.end_process differs: 63 vs 1024
4119:   rec.slc[1].reco.pfp[5].trk.truth.p.start_process differs: 63 vs 1024
...

I can comment on the lines with start_ and end_process - these come from sbnanaobj/#135 that @RachelCoackley correctly pointed out, as the kG4UNKNOWN variable was incremented to 1024.

kjplows · 2025-03-10T11:15:54Z

As per the suggestion to update ref files - that sounds to me like a good idea, especially when dependencies to sbnanaobj, sbnobj, and potentially sbncode are updated. These first two repos will most likely lead to changes in commonly used enums that probably show up in the CI.

RachelCoackley · 2025-03-10T11:39:36Z

rec.slc[0].reco.pfp[2].shw.producer differs: 9999999 vs 0 and rec.slc[0].reco.pfp[2].trk.bestplane differs: -1 vs 1 are related to sbnanaobj#136 where I set default values for these variables and updated the refs with these default values. This PR wasn't included in the trigger (hence the differences!!) 😊

henrylay97 added 6 commits February 17, 2025 04:35

Add bad channels to calib services

2f94077

Skip dead channels

e333022

Make channel status accessible through GeoAlg

13e2e86

Point fcl at bad channel file

6f9d24b

Fix typo

915b1f9

Fix typos

1ee33ab

henrylay97 added crt Cosmic Ray Tagger data features for data processing labels Feb 17, 2025

henrylay97 requested a review from kjplows February 17, 2025 10:56

henrylay97 self-assigned this Feb 17, 2025

kjplows reviewed Feb 17, 2025

View reviewed changes

Better use of enums

016882d

Move to c++ strings

9c4e958

kjplows requested changes Feb 21, 2025

View reviewed changes

Actually on skip explicitly dead channels

723bc8f

kjplows approved these changes Feb 24, 2025

View reviewed changes

henrylay97 marked this pull request as ready for review February 27, 2025 09:01

kjplows moved this from Open pull requests to Testing in SBN software development Feb 28, 2025

bear-is-asleep merged commit 06ca4b5 into develop Mar 10, 2025
3 of 4 checks passed

github-project-automation bot moved this from Testing to Done in SBN software development Mar 10, 2025

bear-is-asleep moved this from Draft to In tagged release in SBND March 2025 production Mar 12, 2025

kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026

CRT Channel Status #641

CRT Channel Status #641

Uh oh!

Conversation

henrylay97 commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Relevant PR links (optional)

Link(s) to docdb describing changes (optional)

Uh oh!

kjplows Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

kjplows Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

kjplows Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

henrylay97 commented Feb 18, 2025

Uh oh!

kjplows Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

henrylay97 commented Feb 24, 2025

Uh oh!

kjplows commented Feb 24, 2025

Uh oh!

bear-is-asleep commented Mar 3, 2025

Uh oh!

FNALbuild commented Mar 3, 2025

Uh oh!

FNALbuild commented Mar 3, 2025

Uh oh!

FNALbuild commented Mar 3, 2025

Uh oh!

FNALbuild commented Mar 3, 2025

Uh oh!

bear-is-asleep commented Mar 4, 2025

Uh oh!

FNALbuild commented Mar 4, 2025

Uh oh!

FNALbuild commented Mar 4, 2025

Uh oh!

FNALbuild commented Mar 4, 2025

Uh oh!

FNALbuild commented Mar 4, 2025

Uh oh!

bear-is-asleep commented Mar 4, 2025

Uh oh!

kjplows commented Mar 7, 2025

Uh oh!

FNALbuild commented Mar 7, 2025

Uh oh!

FNALbuild commented Mar 7, 2025

Uh oh!

FNALbuild commented Mar 7, 2025

Uh oh!

FNALbuild commented Mar 7, 2025

Uh oh!

henrylay97 commented Mar 10, 2025

Uh oh!

RachelCoackley commented Mar 10, 2025

Uh oh!

RachelCoackley commented Mar 10, 2025

Uh oh!

kjplows commented Mar 10, 2025

Uh oh!

kjplows commented Mar 10, 2025

Uh oh!

RachelCoackley commented Mar 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

henrylay97 commented Feb 17, 2025 •

edited

Loading