-
Notifications
You must be signed in to change notification settings - Fork 54
Adding data workflow into the CI #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…are/sbndcode into feature/coackley_ciDataWorkflow
…and mem usage limits
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
differences in the caf stage are related to uninitialised variables (fixed in PR#136 sbnanaobj), not to do with the changes in this PR |
henrylay97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much Rachel - this is a wonderful addition to the CI - much needed!
I have one small comment (see below) but regardless of that I am happy to see this go in.
I do think it would be worth (for your own exposure + for good referencing) having a presentation at an upcoming meeting where you outline the tests added and any decisions you had to make (such as choosing a particular run, a particular stream, removing the choppy filter etc). Perhaps @sjgardiner or @kjplows could comment on whether there would be an SBN AI forum for this?
|
Approved |
vitodb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition to the SBND regression test suites.
Just a minor update in a comment for consistency.
Other than this, all look perfect!
Description
Adding data workflow into the CI. 8 new tests have been created which run on 5 events from run 18266 (off beam zero bias). New tests being added:
This has been tested for both the normal workflow and the update reference file workflow, both work as expected. The trigger of the update reference file workflow can be seen here.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
None
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?
None