Skip to content

Conversation

@RachelCoackley
Copy link
Contributor

@RachelCoackley RachelCoackley commented Mar 5, 2025

Description

Adding data workflow into the CI. 8 new tests have been created which run on 5 events from run 18266 (off beam zero bias). New tests being added:

  • data_offBeamZeroBias_decoders_quick_test_sbndcode
  • data_offBeamZeroBias_decoders_seq_test_sbndcode
  • data_offBeamZeroBias_reco1_quick_test_sbndcode
  • data_offBeamZeroBias_reco1_seq_test_sbndcode
  • data_offBeamZeroBias_reco2_quick_test_sbndcode
  • data_offBeamZeroBias_reco2_seq_test_sbndcode
  • data_offBeamZeroBias_caf_quick_test_sbndcode
  • data_offBeamZeroBias_caf_seq_test_sbndcode

This has been tested for both the normal workflow and the update reference file workflow, both work as expected. The trigger of the update reference file workflow can be seen here.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
None

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
None

@RachelCoackley RachelCoackley added the test GitHub or related test label Mar 5, 2025
@RachelCoackley RachelCoackley self-assigned this Mar 5, 2025
@RachelCoackley
Copy link
Contributor Author

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@RachelCoackley
Copy link
Contributor Author

differences in the caf stage are related to uninitialised variables (fixed in PR#136 sbnanaobj), not to do with the changes in this PR

Copy link
Member

@henrylay97 henrylay97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Rachel - this is a wonderful addition to the CI - much needed!

I have one small comment (see below) but regardless of that I am happy to see this go in.

I do think it would be worth (for your own exposure + for good referencing) having a presentation at an upcoming meeting where you outline the tests added and any decisions you had to make (such as choosing a particular run, a particular stream, removing the choppy filter etc). Perhaps @sjgardiner or @kjplows could comment on whether there would be an SBN AI forum for this?

@bear-is-asleep
Copy link
Contributor

Approved

Copy link
Contributor

@vitodb vitodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition to the SBND regression test suites.
Just a minor update in a comment for consistency.
Other than this, all look perfect!

@kjplows kjplows moved this to Testing in SBN software development Mar 10, 2025
@bear-is-asleep bear-is-asleep merged commit b15162c into develop Mar 10, 2025
@github-project-automation github-project-automation bot moved this from Testing to Done in SBN software development Mar 10, 2025
@kjplows kjplows moved this from Done to Testing in SBN software development Jan 16, 2026
@kjplows kjplows moved this from Testing to 2025 PRs in SBN software development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test GitHub or related test

Projects

Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

6 participants