Merged
Conversation
Contributor
akenmorris
commented
Apr 16, 2026
akenmorris
commented
- Fix Windows install: upgrade torch to 2.8.0 for NumPy 2.x compatibility
- Loosen compactness tolerance in evaluation_compare to 0.10
- Loosen specificity tolerance in evaluation_compare to 0.45 for windows peanut_shared_boundary
The Windows installer pinned torch==2.2.2, which was compiled against NumPy 1.x and crashed on import with the NumPy 2.3.3 pinned in python_requirements.txt. Bump to torch==2.8.0 (with matching torchaudio and torchvision) to align with install_shapeworks.sh. Also add a post-install validation block and reorder the Python package installs to match the sh script.
…s peanut_shared_boundary
Smart App Control on Windows 11 blocks the unsigned scientific Python DLLs (VTK, PyTorch, etc.) that ShapeWorks installs via pip, breaking Python use cases, notebooks, and DeepSSM. Studio's native features are unaffected. - install.md, Windows_README.txt: explain symptom, scope, and how to turn SAC off via the Start menu. - install_shapeworks.bat: detect SAC at install time via Get-MpComputerStatus and warn the user before pip runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.