Skip to content

Doc and test tweaks for ENVPath functions #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mwichmann
Copy link
Collaborator

@mwichmann mwichmann commented Jul 11, 2025

Reword AppendENVPath and PrependENVPath manpage entries.

Add more unit tests for the underlying functions, SCons.Util.AppendPath and SCons.Util.PrependPath (these changes are distinct from the ones in #4742 )

There are no changes to SCons itself.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

Reword AppendENVPath and PrependENVPath manpage entries.

Add more unit tests for the underlying functions,
SCons.Util.AppendPath and SCons.Util.PrependPath

Signed-off-by: Mats Wichmann <[email protected]>
@mwichmann mwichmann added documentation testsuite Things that only affect the SCons testing. Do not use just because a PR has tests. labels Jul 11, 2025
@mwichmann mwichmann moved this to In review in Next Release Jul 11, 2025
CHANGES.txt Outdated
@@ -147,6 +147,8 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER
path munging if a non-default %TEMP% was defined (as in moving to
a Dev Drive). Also some cleanup.
- Improve the wording of Configure methods.
- Improve thw wording of AppendENVPath and PrependENVPath in manpage.
- Add more unit tets to internal AppendPath, PrependPath functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'tets'

RELEASE.txt Outdated
@@ -126,6 +126,8 @@ DOCUMENTATION

- Improve the wording of Configure methods.

- Improve thw wording of AppendENVPath and PrependENVPath in manpage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'thw'

RELEASE.txt Outdated
@@ -169,6 +171,8 @@ DEVELOPMENT
iterative speedup test from 200 to 250. Increasing the workload
should reduce the likelihood that the ninja tests are slower.

- Add more unit tets to internal AppendPath, PrependPath functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'tets'

Signed-off-by: Mats Wichmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation testsuite Things that only affect the SCons testing. Do not use just because a PR has tests.
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants