fix: 优化指示器动画停止，避免信号干扰#229
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a crash reported in SECRANDOM-4A by making the settings window shutdown path more robust: it attempts to stop QFluentWidgets navigation indicator animations without emitting signals that can trigger callbacks after the UI is being torn down.
Changes:
- Block/unblock signals around
indicatorAni.stop()using atry...finallyto avoid signal-driven callbacks during teardown. - Minor change near
show_settings_window_about()(currently introduces an inconsistent line ending on the modified line).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+427
to
+431
| indicator_ani.blockSignals(True) | ||
| try: | ||
| indicator_ani.stop() | ||
| finally: | ||
| indicator_ani.blockSignals(False) |
| self.activateWindow() | ||
| self.raise_() | ||
| self.switchTo(self.aboutInterface) | ||
| self.switchTo(self.aboutInterface) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SECRANDOM-4A. The issue was that: QFluentWidgets' navigation animation callback attempts to access a destroyed
NavigationTreeWidgetafter window closure, causingAttributeError.try...finally块确保即使发生异常，信号也能被重新启用。This fix was generated by Seer in Sentry, triggered by wsxyt. 👁️ Run ID: 1259143
Not quite right? Click here to continue debugging with Seer.