Add check recordType XML element exists before referencing text#3825
Open
rtoepferveruna wants to merge 3 commits intoSFDO-Tooling:mainfrom
Open
Add check recordType XML element exists before referencing text#3825rtoepferveruna wants to merge 3 commits intoSFDO-Tooling:mainfrom
rtoepferveruna wants to merge 3 commits intoSFDO-Tooling:mainfrom
Conversation
…bute for profiles without this child element
|
Thanks for the contribution! Before we can merge this, we need @rtoepferveruna to sign the Salesforce Inc. Contributor License Agreement. |
Contributor
|
@jstvz I've reviewed this change, tested it locally, and implemented with @rtoepferveruna in a repo with active CI builds using CumulusCI. I can't see any risk to adding it as it current would be throwing an exception for anyone hitting the issue. |
jstvz
added
oss-contribution
maintainer-approved
jstvz
approved these changes
Sep 11, 2024
Contributor
jstvz
left a comment
jstvz
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @rtoepferveruna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain objects in Salesforce profile XML schema are not required to have a recordType child element of layoutAssignment node. This fix prevents an exception being thrown when updating orgs with these objects in the profile metadata.