Fixed setting Ambient values #1
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompiled Hades maps have the
Ambientin their root, not within aMaterialparent as HadesMapper currently expects, I'm unsure why this is.This would cause all encoded maps to always have an ambient values of 0 assigned.
To not potentially mess up any current behaviour, I'm simply adding an additional fallback to the root Ambient value in case the Material parent doesn't exist.
Here's some comparisons:
Hades:
Same map encoded for Hades II with missing Ambient values:
Same map encoded for Hades II with fixed Ambient values:
