feat: dark mode image support - #130
Merged
Merged
Conversation
kelvinmanley
requested review from
Gerrit-van-Niekerk,
NicholasDunham,
aLR8,
asalvi0,
dev-pieter,
robyn-thomas and
yandisakat
and removed request for
Gerrit-van-Niekerk,
NicholasDunham,
aLR8,
asalvi0,
dev-pieter,
robyn-thomas and
yandisakat
August 27, 2026 11:41
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in dark-mode support for the title bar brand logo by allowing a separate dark variant to be configured via params.logo_dark.
Changes:
- Introduces
params.logo_darkhandling in the title bar brand partial and conditionally renders light/dark logo variants with theme-specific classes. - Updates the changelog to document the new feature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| layouts/partials/title-bar/brand.html | Adds optional dark-logo param support and emits markup/classes for light vs dark logo variants. |
| CHANGELOG.md | Documents the new params.logo_dark feature entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Zalaras
approved these changes
Aug 27, 2026
dev-pieter
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA_TICKET_URL
What does this PR do?
This PR adds dark mode support for the side nav logo by adding an opt-in
params.logo_darkto swap the title bar logo when dark mode is active. If this parameter is set in a module, the module can utilise the dark variant logo when dark mode is activated.Why is this change needed?
This is required for dark mode
How to test & Screenshots
See: https://github.com/SPANDigital/presidium-js-enterprise/pull/1551/