feat: 新增模板 ”BlueArchive“ 蔚蓝档案#196
Open
VanillaNahida wants to merge 2 commits into
Open
Conversation
Contributor
Reviewer's GuideAdds a new 'BlueArchive' (蔚蓝档案) themed reporting template, including HTML templates for full report, image report, and partial components, and updates the README showcase. Flow diagram for BlueArchive reporting template integrationflowchart TD
Start([Start]) --> Gen["Generate group analysis report"]
Gen --> SelTemplate["Select template: BlueArchive"]
SelTemplate --> Type{Output type}
Type -->|HTML report| HtmlTpl["Render BlueArchive/html_template.html"]
Type -->|Image report| ImgTpl["Render BlueArchive/image_template.html"]
HtmlTpl --> Partials
ImgTpl --> Partials
Partials["Inject partials:
- activity_chart.html
- topic_item.html
- user_title_item.html
- quote_item.html
- chat_quality_item.html"] --> Rendered["BlueArchive-themed report output"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
html_template.htmlandimage_template.htmlfiles are almost completely duplicated; consider extracting the shared layout and styles into a common base template or CSS to reduce maintenance overhead and risk of divergence. - Several external resources (fonts and character images) are hardcoded to specific CDN/HTTP(S) URLs; making these configurable (or serving locally) would improve robustness if those endpoints change or become unavailable.
- Color palettes for dimensions are defined inline in multiple Jinja templates (e.g.
chat_quality_item.htmlandactivity_chart.html); centralizing these color definitions would make it easier to keep the visual style consistent and to tweak in one place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `html_template.html` and `image_template.html` files are almost completely duplicated; consider extracting the shared layout and styles into a common base template or CSS to reduce maintenance overhead and risk of divergence.
- Several external resources (fonts and character images) are hardcoded to specific CDN/HTTP(S) URLs; making these configurable (or serving locally) would improve robustness if those endpoints change or become unavailable.
- Color palettes for dimensions are defined inline in multiple Jinja templates (e.g. `chat_quality_item.html` and `activity_chart.html`); centralizing these color definitions would make it easier to keep the visual style consistent and to tweak in one place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
|
感谢贡献，能不能看看效果图 可能要等我考完期末再来 review 了，抱歉 |
Author
你好，效果图我已经放在第一个评论的描述里了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Change?
新增模板
BlueArchive，用来创建蔚蓝档案风格的群聊分析报告模板Demo
BlueArchive（蔚蓝档案）
Summary by Sourcery
Add a new BlueArchive-themed group chat analysis report template and wire it into the existing reporting system.
New Features:
Documentation: