2week #7
Open
2week #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYEON10
reviewed
Jul 15, 2023
|
|
||
| public class CamControl : MonoBehaviour | ||
| { | ||
| public GameObject player; //����ٴ� ������Ʈ ���� |
Owner
There was a problem hiding this comment.
public 은 보안상 공개되어도 상관없는 수치에 붙이면 좋고, 이런 경우에는 굳이public 으로 설정할 필요가 없음!
[Serialized Field]를 붙이면 public 으로 했을 때와 동일하게 Hierarchy에 뜸
SYEON10
reviewed
Jul 15, 2023
| } | ||
|
|
||
|
|
||
| if (toggleView == 1) |
Owner
There was a problem hiding this comment.
이렇게 번호로 하면 가독성이 떨어집니다! 코드 작성하다 실수할 수도 있어요.
enum으로 정의하면 더 좋아요.
가독성도 좋고 enum은 int로 처리가 가능해서 가볍게 사용할 수 있음.
언어 차원 에서 제공하는 기능이라 c# enum 혹은 unity enum 찾아보면 사용방법 나올 거예요
SYEON10
reviewed
Jul 15, 2023
| { | ||
|
|
||
|
|
||
| if (Input.GetKeyDown("1")) |
Owner
There was a problem hiding this comment.
이건 과제 같은 느낌으로 보면 좋을 것 같은데... 함 생각해보고 안되면 말아도 됨.
메이플 같은 거 하면 우리가 단축키 직접 설정할 수 있잖아
그런 방법을 사용하려면 이렇게 구현하면 안되겠지?
이 경우 어떻게 할 수 있을까?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이게맞나요..