-
Notifications
You must be signed in to change notification settings - Fork 14
Add more tests #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests #301
Conversation
|
Thank you! We can discuss what kind of tests we want to run. For example, malformed tests are testing wabt, do we need them? |
e6a4980 to
d024da4
Compare
|
Thanks for your great contribution!
|
|
Initially we just wanted the files to be seperated so it's easier to keep track of "other" tests but I will merge it if that is prefered. |
944f194 to
46a9d01
Compare
bfbedec to
d149148
Compare
d149148 to
8bb7f74
Compare
|
@clover2123 We have been trying out things in this patch and started to wonder how should the tests be added. Just to clarify all of these tests have been collected from But the important thing is:
We would not add tests that are still failing though. Lastly, there are still some tests that we are looking at. Should we contiue looking into them and search for more or should we rather focus on merging these into walrus? Also, should we maybe introduce a new CI run for more complicated tests that take more time? |
8bb7f74 to
90c56e0
Compare
87ba7c0 to
7fff43e
Compare
7fff43e to
5d28f65
Compare
|
For license concers, as far as I know dhrystone does not have a definitive license, it is just free to use, but please correct me if I am wrong. |
5d28f65 to
ac2652b
Compare
Add a script to build benchmark programs to test walrus
ac2652b to
9a0d428
Compare
zherczeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is just a demonstration of expanding the testing system of Walrus.
Add tests:
This will be changed to fit the right licenses, it is just a demonstration.