Skip to content

Add missing realm fields and custom NetworkProtocol type#419

Open
HashimTheArab wants to merge 2 commits intoSandertv:masterfrom
HashimTheArab:feat/realm-fields
Open

Add missing realm fields and custom NetworkProtocol type#419
HashimTheArab wants to merge 2 commits intoSandertv:masterfrom
HashimTheArab:feat/realm-fields

Conversation

@HashimTheArab
Copy link
Copy Markdown
Contributor

  • Adds missing fields to RealmAddress struct
  • Adds a typed realms.NetworkProtocol type to define constants for known realm network protocols and add validator method. This will be required when we want to do a full nethernet implementation, makes it easier to catch when mojang adds a new protocol type, and prevents downstream code from defining duplicate constants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant