Open
Conversation
Collaborator
Author
|
effect so far ScalablyTyped/Distribution@ff1c1ce |
27400df to
10c5a16
Compare
10c5a16 to
81f1a8f
Compare
… long as name and type parameters are the same.
81f1a8f to
bbad63e
Compare
d3bbca8 to
ad9f226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far we've been pretty pedantic in the handling of things like re-exported types.
In most cases
Barhas pointed tolibfoo.Fooso far, while the intention was really something compatible withlibfoo/impl/foo.FooIn the name of pragmatism, assert that if a class has a parent with the same name and type parameters, accept that in the place of the child class.