fix: Remove CREATE_DATASET_GROUPS from .env#774
Merged
Conversation
|
Member
Author
thanks! i don't have the permission to merge, so please do it if happy with the change. |
|
🎉 This PR is included in version 3.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
is the sdk failure a false positive? I can't think of any reason it would fail. |
Member
https://github.com/SciCatProject/scicatlive/actions/runs/23851617117/job/69533066377#step:3:51603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When CREATE_DATASET_GROUPS is explicitly set, only those groups are allowed to create / update (i.e. PATCH) datasets. Even an authenticated user who belongs to dataset's ownerGroup will be denied if she doesn't belong to CREATE_DATASET_GROUPS (or ADMIN_GROUPS or CREATE_DATASET_PRIVILEGED..)
If CREATE_DATASET_GROUPS is not set, it defaults to #all (code) - that means any authenticated user is allowed to call PATCH endpoint, and the authorization is later decided in the controller by instance authorization check.
Fixes
Changes
Changes checklist
Modified Service?
New Service?