Allow system level metadata information#3892
Merged
AayushSabharwal merged 8 commits intoSciML:masterfrom Sep 11, 2025
Merged
Conversation
asinghvi17
reviewed
Aug 25, 2025
Member
|
InterfaceI is failing |
Member
Author
|
It's seemingly related to units, is that something this PR could break? I did rebase this branch recently as well |
Member
|
The error is specifically in the test added in this PR, and there is no unit failure on master or the recently opened #3912 so it is likely that something here is wrong. |
Member
Author
|
Hmm, unable to reproduce locally. I get struct Author end
struct MyVersion end
struct License end
struct Category end
struct Tags end
struct MyBool end
struct NewInt end
@mtkmodel TestMetadataModel begin
@metadata begin
Author = "Test Author"
MyVersion = "1.0.0"
License = "MIT"
Category => "example"
Tags = ["test", "demo", "metadata"]
MyBool => false
NewInt => 1
end
@parameters begin
k = 1.0, [description = "Gain parameter"]
end
@variables begin
x(t), [description = "State variable"]
y(t), [description = "Output variable"]
end
@equations begin
D(x) ~ -k * x
y ~ x
end
endjulia> @named test_model = TestMetadataModel()
Model test_model:
Equations (2):
2 standard: see equations(test_model)
Unknowns (2): see unknowns(test_model)
x(t): State variable
y(t): Output variable
Parameters (1): see parameters(test_model)
k [defaults to 1.0]: Gain parameter |
Member
|
Does it reproduce if you run the entire testset locally? Or just that file? |
Member
Author
|
Let me try running the whole test suite locally. |
AayushSabharwal
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Ref #3734
Add any other context about the problem here.
Are there cases where there are expression evaluations anywhere for the model parsing? Currently everything is delayed, but that means local variables are not referred to properly, and
escwill simply convert the escaped expression, whereas we need it as parse/ expansion time.