feat: [AI] use LinearProblem for linear initialization systems in MTKBase#4366
Open
AayushSabharwal wants to merge 1 commit intomasterfrom
Open
feat: [AI] use LinearProblem for linear initialization systems in MTKBase#4366AayushSabharwal wants to merge 1 commit intomasterfrom
LinearProblem for linear initialization systems in MTKBase#4366AayushSabharwal wants to merge 1 commit intomasterfrom
Conversation
AayushSabharwal
changed the title
LinearProblem for linear initialization systems in MTKBaselLinearProblem for linear initialization systems in MTKBase
| u0 = u0_constructor(ones(eltype(linprob.A), size(linprob.A, 2))) | ||
| ) | ||
| end | ||
| return SCCNonlinearProblem((linprob,), (Returns(nothing),), parameter_values(linprob), true; sys) |
Member
There was a problem hiding this comment.
That's a bit of a kludge, we should just make a linearproblem?
Member
Author
There was a problem hiding this comment.
LinearProblem looks and works significantly different from most other *Problems in SciML. The initialization infrastructure doesn't like working with it directly. SCCNonlinearProblem basically serves as a "make this look like a NonlinearProblem" wrapper while still actually using LinearSolve.jl directly.
AayushSabharwal
force-pushed
the
as/mtkbase-initprob-linprob
branch
from
d048230 to
881d802
Compare
…TKBase Co-authored-by: Claude <noreply@anthropic.com>
AayushSabharwal
force-pushed
the
as/mtkbase-initprob-linprob
branch
from
881d802 to
24f922c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.