Allow ODE solutions to carry traced return codes - #1564
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Allow ODE solutions to carry traced return codes#1564ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.151.0 Agent-Model: unknown Agent-Session: local session ID 01a04f92-0d12-7990-926c-f3e5a23f3a31
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
ODESolution.retcodewas fixed toReturnCode.T. An OrdinaryDiffEq solve staged insideReactant.@jitmust carry a traced return code through the device loop, so Reactant cannot reconstruct the solution with that concrete field type. This appends the return-code type toODESolution's parameters and keeps the documentedODESolution{T,N}constructor unchanged. It also letssuccessful_retcodeclassify scalar carriers convertible toReturnCode.T.This is the SciMLBase prerequisite for the OrdinaryDiffEq Reactant solve work. The generic
successful_retcodefallback intentionally matches the one in #1563; whichever PR merges second should drop the duplicate line during conflict resolution.Verification
After rebasing onto current
upstream/master:The default CondaPkg-backed QA run also failed on unchanged master because the machine's shared Pixi cache contains zero-byte Python standard-library files. A standalone Pixi reproducer produced the same
init_fs_encodingfailure; unchanged master passed all 123 QA assertions with a fresh cache. No test was skipped or silenced.Reviewer judgment
Appending a type parameter is observable to downstream code that spells every
ODESolutionparameter explicitly. The documented constructor takes only{T,N}and repository tests cover it, but the 3.51.0 minor bump should be reconsidered if full structural parameterization is treated as supported public API.Not verified
🤖 Generated with Codex CLI 0.151.0 (model: unknown). Session: local session ID 01a04f92-0d12-7990-926c-f3e5a23f3a31