Fix RIP-200 hmac import scope#6670
Open
Thanhdn1984 wants to merge 1 commit into
Open
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
MolhamHamwi
reviewed
May 31, 2026
Contributor
MolhamHamwi
left a comment
There was a problem hiding this comment.
Reviewed node/rewards_implementation_rip200.py in PR #6670.
Two specific observations:
- Moving
import hmacto module scope is safe here becausesettle_rewards()is the only current consumer (hmac.compare_digest(...)), and the module already imports other stdlib dependencies at top level. That keeps privileged endpoint auth code from depending on an inline import inside the route handler. - I checked the updated head with
py_compile; the file still compiles after the import-scope change, so the patch does not introduce a syntax/import-order regression in this module.
Why I liked it: this is a minimal, low-risk cleanup around a security-sensitive constant-time comparison path rather than a broad refactor.
I received RTC compensation for this review.
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hmacimport to module scope innode/rewards_implementation_rip200.pycompare_digestavailable for all registered RIP-200 routes instead of only the settle handlerTest
python3 -m compileall -q node/rewards_implementation_rip200.pyFixes #6668
Bounty/miner id:
keon0711