Skip to content

Fix incorrect casting from DateTime<Local> to ChronoDateTimeWithTimeZone in Value::Array #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Fix incorrect casting from DateTime<Local> to ChronoDateTimeWithTimeZone in Value::Array #933

merged 1 commit into from
Jul 31, 2025

Conversation

Huliiiiii
Copy link
Member

@Huliiiiii Huliiiiii commented Jul 31, 2025 •
edited
Loading

PR Info

Bug Fixes

  • Fix incorrect casting from DateTime<Local> to ChronoDateTimeWithTimeZone in Value::Array

@Huliiiiii Huliiiiii changed the title Fix wrong casting of array of Datetime<FixedOffset> Fix wrong casting of Value::Array of ChronoDateTimeWithTimeZone Jul 31, 2025
@Huliiiiii Huliiiiii changed the title Fix wrong casting of Value::Array of ChronoDateTimeWithTimeZone Fix incorrect casting from DateTime<Local> to ChronoDateTimeWithTimeZone in Value::Array Jul 31, 2025
@Huliiiiii Huliiiiii changed the title Fix incorrect casting from DateTime<Local> to ChronoDateTimeWithTimeZone in Value::Array Fix incorrect casting from DateTime<Local> to ChronoDateTimeWithTimeZone in Value::Array Jul 31, 2025
tyt2y3
tyt2y3 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. why have I missed it for so long

@tyt2y3 tyt2y3 merged commit 6f70bf3 into SeaQL:master Jul 31, 2025
20 checks passed
tyt2y3 pushed a commit that referenced this pull request Jul 31, 2025
@Huliiiiii @tyt2y3
Fix incorrect casting from DateTime<Local> to `ChronoDateTimeWithTi…
d6d8b24 
…meZone` in `Value::Array` (#933)

## PR Info
- Closes #662


## Bug Fixes

- [x] Fix incorrect casting from `DateTime<Local>` to
`ChronoDateTimeWithTimeZone` in `Value::Array`
@Huliiiiii Huliiiiii deleted the chrono-cast branch July 31, 2025 22:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025

🎉 Released In 0.32.7 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@Huliiiiii Huliiiiii mentioned this pull request Aug 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong casting of array of Datetime<FixedOffset>
2 participants
@Huliiiiii @tyt2y3