Refactor conversions around qualified identifiers #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How about renaming |
Member
Author
|
Wait a second. Now I'm not sure if this will actually help me to model |
Member
Author
I don't mind, both seem fine to me |
Expurple
added a commit
that referenced
this pull request
Aug 13, 2025
As discussed here: #827 (comment) ## PR Info - Closes #827 - Dependencies: - #921 - #953 ## Changes The PR has been updated. The up-to-date description is in the changelog in the diff. --- **Original, outdated note:** Merge after #921. Marking as draft until then. The first commit comes as a dependency from that PR. If you want to review the diff before merging that PR, review only the second commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some annoying repetition in this area.
TableNameandColumnNameeach had three copy-pastedFromimpls. Now they have one, which will be easier to copy-paste when I addTypeNameandFunctionName. I came up with this while re-doing #922 to addTypeName.Related to #927.
types.rsis getting too long and starting to have visible disjoint "submodules", so I started splitting it.PR Info
cast_as_quoted#922New Features