Remove blocking behavior workaround in MCP ClientSession #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3c2c0f. This workaround is not necessary anymore and now harmful since the fix is applied in MCP 1.6.0. modelcontextprotocol/python-sdk#325
|
This would require bumping the MCP sdk version, which has some breaking changes that need to be addressed first. |
|
Sure thing, what would those breaking changes consist of? I assumed this to be safe as this version was already in the allowed version range of 1.2.0 to 1.7.1 and created no dependency issues when personally testing. MCP 1.7.1 is automatically chosen when solving dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d3c2c0f. This workaround is not necessary anymore and now harmful since the fix is applied in MCP 1.6.0.
modelcontextprotocol/python-sdk#325
Fixes #76