Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When someone shares a link to a text on Sefaria, many apps show a preview card with a generated image of the passage. In some cases that image showed odd fragments like
or instead of normal spaces.On newer server setups, generating that image could also fail outright because the graphics library we use stopped supporting an older API. When that happened, the site fell back to a generic logo-only image instead of the passage.
This change cleans the text before drawing it and updates the code to work with current versions of the image library so previews look right and generate reliably.
Code Changes
File:
sefaria/image_generator.pycleanup_and_format_texthtml.unescapeafter stripping HTML tags so named/numeric entities ( , ,&#…;, etc.) become real characters instead of literal&…;strings in the PNG.\u00a0,\u2000–\u200a,\u202f,\u205f) to ASCII space for consistent PIL layout.\u200b–\u200d,\u2060,\ufeff(covers common ZWSP/ZWNJ/ZWJ/word-joiner/BOM cases).text: return""early to avoid errors downstream.