Remove alpaka procModfier from workflows in which it is no longer useful #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modules seem to have been supersed by more generic ones: - SiPixelCompareVertexSoA -> SiPixelCompareVertices - SiPixel*CompareRecHitsSoA -> SiPixel*CompareRecHits - SiPixel*CompareTrackSoA -> SiPixel*CompareTracks - SiPixel*MonitorRecHitsSoA -> SiPixel*MonitorRecHitsSoAAlpaka - SiPixel*MonitorTrackSoA -> SiPixel*MonitorTrackSoAAlpaka - SiPixelMonitorVertexSoA -> SiPixelMonitorVertexSoAAlpaka
…heir aliased types in classes_def.xml In ROOT presently the type alias gets listed in the rootmap file only if the alias is requested before the real type. Having the type alias in the rootmap file is necessary to avoid header parsing for the execution of the read rules that use the type alias names.
If cmsRun fails during the test, now reports what the cmsRun logged.
…aliased-to types This should avoid ROOT header parsing
They are not in DataFormats, so they are allowed to be transient only.
…roducer accordingly
Fixes for uninitialized variable use detected by valgrind
Adding track path length resolution plots to MtdTracksValidation
Use more requires in EventSetup code
Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment
…d_geomMigrate update unit test Miscellanea post integration of cms-sw#49725
Move AtomicPtrCache dictionary to proper packages
L1-uGT emulator: fix to `AXOL1TL`'s "Pt" inputs
- Kernels work divider of 256u from optimization (cms-sw#47629 (comment)) - Bug fix for events with `nStrips` = 0 (https://gist.github.com/mmusich/a7928a000b4eb6ea00ac5ab9cfa2238e) -- Fix for packet code of non-lite ZS buffers (https://gist.github.com/mmusich/a7928a000b4eb6ea00ac5ab9cfa2238e) - Use Acc1D directly (cms-sw#47629 (comment)) - Fix errors in static analysis (cms-sw#47629 (comment)) Co-authored-by: Andrea Bocci <[email protected]>
…0pre1 SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU
…_unit_test fix unit test `createTestDBObjects` after integration of cms-sw#49725
…sMonitoring bug-fix: use `hltOnlineBeamSpot` in `hltWithPixelTracks` and `hltPixelLessTracks`
…onary
Improve `PortableHost{Collection,Object}` dictionary declarations
suppress loop unroll warning in LSTCore
…_removeUnusedFlag Remove unused flag from standalone LST
…gHBHERechitTime Introduce DQM for `Run3ScoutingHBHERecHit` time
auto detect first vertex with Higgs in children list
Added fillDescriptions to more classes in FWCore
Simulation: prevent exception if trackId larger than 200M
VourMa
force-pushed
the
CMSSW_16_0_0_pre3_removeAlpakaFromWFs
branch
from
59c9798 to
b10522a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Patatrack quadraplet pixel tracks were made the default in CMSSW, so the
alpakamodifier was rendered useless in a quite a few workflows which was using it to enable Patatrack pixel tracking. This PR removes thealpakaprocModifier from these workflows. One workflow is completely removed, as it was duplicate of another, and that leads to a small change in the workflow numbering.The PR was validated by making sure that all the modified workflows succeed.