Remove alpaka procModfier from workflows in which it is no longer useful#220
Remove alpaka procModfier from workflows in which it is no longer useful#220
Conversation
| upgradeWFs['HLTTiming75e33SingleIter'].step2 = { | ||
| '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing,VALIDATION:@hltValidation', | ||
| '--procModifiers': 'alpaka,singleIterPatatrack', | ||
| '--procModifiers': 'singleIterPatatrack', |
There was a problem hiding this comment.
I did a git grep alpaka.to and found alpaka.toReplaceWith(_HgcalLocalRecoUnseededSequence, in HLTrigger/Configuration/python/HLT_75e33
that's in 16_0_0_pre2.
If these were strictly TrackingOnly workflows, then the change seems OK.
I'm less sure for the general table.
There was a problem hiding this comment.
Indeed, the alpaka procModifier is still used to enabled the HGCal heterogenous reconstruction, and hence it is kept in the general workflow (0.751) as well as the dedicated TICL one (0.771). I intend to bring this up to the HGCal developers and see if it's still useful there but this is beyond the scope of this PR.
I also noticed these two ESProducers that are enabled by the alpaka procModifier:
- https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltESPSiPixelGainCalibrationForHLTSoA_cfi.py
- https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/HLT_75e33/eventsetup/hltESPSiPixelCablingSoA_cfi.py
I don't know how these are useful but they do not affect the workflows that I changed. I intend to ask about them in the PR as well.
slava77
left a comment
slava77
left a comment
There was a problem hiding this comment.
approving based on the discussion during the meeting. The point is to highlight to HGCAL that in these (or all related to GPU) workflows we probably want alpaka-HGCAL
VourMa
force-pushed
the
CMSSW_16_0_0_pre3_removeAlpakaFromWFs
branch
from
59c9798 to
b10522a
Compare
2 participants
Recently, Patatrack quadraplet pixel tracks were made the default in CMSSW, so the
alpakamodifier was rendered useless in a quite a few workflows which was using it to enable Patatrack pixel tracking. This PR removes thealpakaprocModifier from these workflows. One workflow is completely removed, as it was duplicate of another, and that leads to a small change in the workflow numbering.The PR was validated by making sure that all the modified workflows succeed.