Fix standalone issue with Acc concept by removing unnecessary code #221

ariostas · 2026-01-12T19:22:15Z

No description provided.

…dder numbers

These modules seem to have been supersed by more generic ones: - SiPixelCompareVertexSoA -> SiPixelCompareVertices - SiPixel*CompareRecHitsSoA -> SiPixel*CompareRecHits - SiPixel*CompareTrackSoA -> SiPixel*CompareTracks - SiPixel*MonitorRecHitsSoA -> SiPixel*MonitorRecHitsSoAAlpaka - SiPixel*MonitorTrackSoA -> SiPixel*MonitorTrackSoAAlpaka - SiPixelMonitorVertexSoA -> SiPixelMonitorVertexSoAAlpaka

If cmsRun fails during the test, now reports what the cmsRun logged.

…roducer accordingly

The type was deprecated in C++23. Switch to using new with alignment specifier.

- switched from recursive types to fold expressions with lambdas - use constexpr - switch to using expressions

… the V19 geometry

- adhere to non member variable naming conventions - avoid adding useless variables

- being symmetric with the delete case was viewed as desireable based on PR discussion - allocate only what is needed without padding at end of array as we are now allocating just bytes rather than a type using max_alignment size.

…s values

Removed use of deprecated std::aligned_storage

Phase 2 - Add new tracker DQM histograms showing OT cluster position in 2S modules & ladders

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous

…eCluster_v1 Miscellaneous fixes to SiStripApproximateCluster_v1

…gPFProducer Fix a variable name in HLTScoutingPFProducer: from dxy(z)Error to dxy(z)Sig

…ithtime_16_0_0_pre4 Add time info to Run3ScoutingHBHERecHit

…val2025

…duce_LogError_noise Reduce LogError noise when using (E)EoR3 CPE conditions

Update HF FG thresholds for 2025 PbPb

Phase2-hgx364W Extend the tests for finding errors in iD->position and viceve rsa for the V19 geometry

…edComment ETL digitization: update comments on TDC window parameters

Phase 2 Tracker: Summary histograms for release validation

Use the alpaka Acc concept

set `relval2025` autoHLT key to `Fake2`

btvNano: add abort condition for genParticle mother search

Phase 2 geometry deprecation

…ules Add fillDescriptions to ToyModules.cc classes

slava77 · 2026-01-12T20:00:14Z

not directly on topic, but still: computeRadiusFromThreeAnchorHits is used off-acc only to compute "T3 pt" (t5_t3_pt branch) and I'm not sure this use case is justified.

If I understand correctly, https://github.com/cms-sw/cmssw/blob/e069dffbeeeb4a0fc44beda6b3890b040afed7d7/RecoTracker/LSTCore/standalone/code/core/write_lst_ntuple.cc#L2569-L2577
the pt is computed from the first 3 hits (not from the anchor hits); is it intended or is it a bug?

If the intention was to have anchor hits, then it's more practical to use radius from the T3 SoA.
if this kind of pt is intentional , perhaps a more clear name can be used (like t5_t3_hits012_pt

this was apparently originally from @GNiendorf in #61 and the code there used anchor hits
https://github.com/SegmentLinking/cmssw/pull/61/changes#diff-94b5a9eab127b1781b75f4576abb46b96752badbbb5d7fe40efbe28dfe55b549R620
However the implementation changed in #136 https://github.com/SegmentLinking/cmssw/pull/136/changes#diff-94b5a9eab127b1781b75f4576abb46b96752badbbb5d7fe40efbe28dfe55b549R647-R654

GNiendorf · 2026-01-12T20:12:00Z

It looks like this t5_t3_pt variable and t4_t3_pt are not used and can be removed. @ariostas @slava77

slava77

only 74a8a34 is the actual change.
Looks OK

I'm not sure if a CI run is possible

ariostas · 2026-01-13T14:26:27Z

The CI should still work. I'll submit it upstream once it's done.

/run standalone
/run checks

github-actions · 2026-01-13T14:52:06Z

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     30.8    376.4    272.9    125.7     47.5    689.0     11.4    126.3    133.1    179.6      2.4    1995.0    1275.2+/- 303.4     611.8   explicit[s=4] (target branch)
   avg     30.9    377.4    272.1    125.9     47.6    683.8     11.4    125.4    133.0    180.5      1.7    1989.7    1275.0+/- 300.7     611.9   explicit[s=4] (this PR)

slava77 · 2026-01-16T15:05:18Z

since it's taking so long to get this fix merged, I'd like to propose an update for the CI: to add a manually maintained list of fixup PRs to be added on top of the master for both the baseline and the topic test. This additional PR will be mentioned in the message for results.
@ariostas do you think this will work?

ariostas · 2026-01-16T15:16:21Z

Yeah, I've been thinking of making some improvements to the CI and I was thinking of something along these lines. I'll work on that

ferencek and others added 30 commits June 6, 2025 15:43

reduce LogError noise when using (E)EoR3 CPE conditions

d04ff87

Add cluster position histograms for 2S modules

a52259d

Code format

b99c525

Add Delta Phi summary histos for OT Clusters

81f0b98

RelVal: Add OT RecHit delta phi summary histograms

b6ccd89

Add relval IT cluster delta phi summary histograms

92f046d

Add IT Rechit delta phi histograms

86fa5c5

Remove hardcoded values and add iterator to calculate total module/la…

e93f1ab

…dder numbers

Improve readability of module-counter

735e8c8

Update HF FG thresholds for 2025 PbPb

6c7a0d0

btvNano: add abort condition for genParticle mother search

2fa97e9

Avoid adding TF2 and TF3 to global list of functions

57e5b49

Additional info when tests fail in DQMOffline/Configuration

f9a023d

If cmsRun fails during the test, now reports what the cmsRun logged.

add time info to Run3ScoutingHBHERecHit and update HLTScoutingRecHitP…

c8746be

…roducer accordingly

Removed use of deprecated std::aligned_storage

afa4db5

The type was deprecated in C++23. Switch to using new with alignment specifier.

Use std::byte for storage type in edm::SoATuple

127cf63

Use std::assume_aligned instead of compiler specific function

9c23299

btvNano: move mother check into while condition

40423ca

Must call explicit alignment form of delete

7bd5d3a

Modernized SoATupleHelper

4cfde9a

- switched from recursive types to fold expressions with lambdas - use constexpr - switch to using expressions

Extend the tests for finding errors in iD->position and viceversa for…

27c48aa

… the V19 geometry

Code check

161b906

Miscellaneous fixes to SiStripApproximateCluster_v1

bd2a1e4

- adhere to non member variable naming conventions - avoid adding useless variables

deprecate old geometries in Configuration/Geometry

cdb1817

remove workflows for deprecated geometries

cea9176

fix an old default

b3a46fd

Implement comments in 49436 and add HLT customisation function.

bfb6d29

switched to explicit operator new

4eb084f

- being symmetric with the delete case was viewed as desireable based on PR discussion - allocate only what is needed without padding at end of array as we are now allocating just bytes rather than a type using max_alignment size.

rename dxy(z)Error to dxy(z)Sig as their are significances and not ab…

5f47610

…s values

cmsbuild and others added 19 commits January 7, 2026 22:33

Merge pull request cms-sw#49712 from Dr15Jones/deprecate_aligned_storage

5cf58d3

Removed use of deprecated std::aligned_storage

Merge pull request cms-sw#49482 from ljuckett/DQM_cluster_plots

2476b25

Phase 2 - Add new tracker DQM histograms showing OT cluster position in 2S modules & ladders

Merge pull request cms-sw#49697 from makortel/cudaDQMRemove

d82850b

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous

Merge pull request cms-sw#49722 from mmusich/mm_fix_SiStripApproximat…

6139e4d

…eCluster_v1 Miscellaneous fixes to SiStripApproximateCluster_v1

Merge pull request cms-sw#49735 from silviodonato/VarNamingHLTScoutin…

36c0b58

…gPFProducer Fix a variable name in HLTScoutingPFProducer: from dxy(z)Error to dxy(z)Sig

Merge pull request cms-sw#49715 from patinkaew/scouting_hbhe_rechit_w…

9eb4c9a

…ithtime_16_0_0_pre4 Add time info to Run3ScoutingHBHERecHit

Use the alpaka Acc concept

05250ba

set relval2025 autoHLT key to Fake2

cd75478

make provisionally the 2025 re-HLT workflows run GRun instead of @rel…

e12f4df

…val2025

Merge pull request cms-sw#48263 from CMSTrackerDPG/SiPixelTemplate_re…

8ba1d27

…duce_LogError_noise Reduce LogError noise when using (E)EoR3 CPE conditions

Merge pull request cms-sw#49677 from stahlleiton/FG_CMSSW_16_0_X

0ae8c9c

Update HF FG thresholds for 2025 PbPb

Merge pull request cms-sw#49719 from bsunanda/Phase2-hgx364W

4b12a81

Phase2-hgx364W Extend the tests for finding errors in iD->position and viceve rsa for the V19 geometry

Merge pull request cms-sw#49736 from martinamalberti/mm_ETLDigi_updat…

4af1283

…edComment ETL digitization: update comments on TDC window parameters

Merge pull request cms-sw#49737 from ljuckett/relval_summary_hists

fa5ade3

Phase 2 Tracker: Summary histograms for release validation

Merge pull request cms-sw#49748 from fwyzard/use_alpaka_Acc_concept

d6e474b

Use the alpaka Acc concept

Merge pull request cms-sw#49747 from mmusich/mm_relval2025asFake

2e087f9

set `relval2025` autoHLT key to `Fake2`

Merge pull request cms-sw#49706 from mseidel42/btvNanoMotherFix

abc9bf9

btvNano: add abort condition for genParticle mother search

Merge pull request cms-sw#49725 from kpedro88/Phase2-WF84

46041a5

Phase 2 geometry deprecation

Merge pull request cms-sw#49750 from Dr15Jones/fillDescriptionsToyMod…

71b6d4f

…ules Add fillDescriptions to ToyModules.cc classes

ariostas force-pushed the master branch from 283f511 to 778220f Compare January 12, 2026 20:23

Remove unnecessary code that is causing issues with Acc concept

74a8a34

ariostas force-pushed the ariostas/fix_standalone branch from e7ee3b1 to 74a8a34 Compare January 12, 2026 21:28

ariostas changed the title ~~Fix standalone issue with Acc concept by also accepting DevCpu~~ Fix standalone issue with Acc concept by removing unnecessary code Jan 12, 2026

slava77 approved these changes Jan 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix standalone issue with Acc concept by removing unnecessary code #221

Fix standalone issue with Acc concept by removing unnecessary code #221

Uh oh!

ariostas commented Jan 12, 2026

Uh oh!

slava77 commented Jan 12, 2026

Uh oh!

GNiendorf commented Jan 12, 2026 •

edited

Loading

Uh oh!

slava77 left a comment

Uh oh!

ariostas commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

slava77 commented Jan 16, 2026

Uh oh!

ariostas commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Fix standalone issue with Acc concept by removing unnecessary code #221

Are you sure you want to change the base?

Fix standalone issue with Acc concept by removing unnecessary code #221

Uh oh!

Conversation

ariostas commented Jan 12, 2026

Uh oh!

slava77 commented Jan 12, 2026

Uh oh!

GNiendorf commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slava77 left a comment

Choose a reason for hiding this comment

Uh oh!

ariostas commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

slava77 commented Jan 16, 2026

Uh oh!

ariostas commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

GNiendorf commented Jan 12, 2026 •

edited

Loading