Conversation
|
|
||
| ies:AccentShape a sh:NodeShape ; | ||
| sh:severity sh:Warning ; | ||
| sh:targetClass ies:Accent . |
There was a problem hiding this comment.
in SHACL it's standard to use the targetClass as the NodeShape, like this:
ies:Accent a sh:NodeShape ;
sh:severity sh:Warning .
There was a problem hiding this comment.
There was a problem hiding this comment.
I did it that way as that is how their present SHACL was done. It is an easy enough change to make if required. It would actually simplify the code or we could make it an option to add a suffix or not
| sh:targetSubjectsOf ies:cookieOriginSite . | ||
|
|
||
| ies:cookieOriginSiteRangeShape a sh:NodeShape ; | ||
| sh:class ies:Webpage ; |
There was a problem hiding this comment.
sh:class belongs on property shape only, not node shape. Please check
There was a problem hiding this comment.
sh:class does not have a domain specified in the shacl ontology only a range of rdfs:Class. These shapes could be changed to an sh.node property which points to the NodeShape of the class which in turn would validates that it is an rdfs:Class, but I don't think it is invalid as it is.
|
|
||
| td:TestClassAShape | ||
| a sh:NodeShape ; | ||
| sh:property [ sh:class td:TestClassD ; |
There was a problem hiding this comment.
I'd suggest property shapes get their own IRI. I've often needed to refer to them directly.
2 participants
No description provided.