Conversation
* Adds CI for MW 1.43 * Uses gesinn-it-pub/docker-compose-ci for CI * Runs linting, phpcs and more * Fixes some phpcs errors - although not all. Fixes #103
|
@gesinn-it-gea / @gesinn-it-ilm requires gesinn-it-pub/docker-compose-ci#9 to be merged. |
|
Hmm even with that it is still throwing "Fatal error: Uncaught ExtensionDependencyError: SemanticScribunto requires Scribunto to be installed." |
|
Oh I missed a few places in gesinn-it-pub/docker-compose-ci#9. Although I think it has to be published for things to take affect? idk. |
|
Have no idea how to fix: |
|
@gesinn-it-ilm @gesinn-it-gea not sure how to resolve ^? Unless it doesn't work on my Mac in docker. (I have a M1 Mac). The error in GitHub ci is because the gesinn-it-pub/docker-compose-ci#9 needs merging. For some reason it doesn't use the current build checkout. |
is still happening. I dunno if there's suppose to be a deployment of that change (CI?) |
|
For another repo I implemented a workflow to schedule automatic updates of docker-compose-ci: https://github.com/gesinn-it-pub/IDProvider/blob/master/.github/workflows/update-submodules.yml If you like this approach, you can add it to other repos as well. Instead of running this only on one day, we can run it daily |
|
I'm not using SemanticScribuntu. Maybe the way it is installed by docker-compose-ci needs to be changed (e.g. using composer to get the deps). Or make the deps being installable via docker-compose-ci |
I’m not sure. It works locally hence the error about lua returning that status number. |
|
I see that REL1_39 isn’t being supplied to where it fetches Scribunto which would be a problem. |
|
For some reason phpunit is now in an infinite loop. I don't know why. |
|
I get: |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Fixes #103