Top-Right QS: Small Updates#66
Merged
Merged
Conversation
TR-01: Fix media queries (767px instead of 991px) for Position: static on the ul#suggestions TR-02: Remove list attribute on the Combobox input to avoid confusion with screen readers (long-term solution is through the Header AEM)
Contributor
Author
|
@Garneauma sorry seems like I had to recreate the PR #64 with the update you requested |
Garneauma
approved these changes
Apr 16, 2026
Yves-Denis
approved these changes
Apr 16, 2026
Yves-Denis
left a comment
Yves-Denis
left a comment
There was a problem hiding this comment.
Security Assessment Completed - Passed, no issues identified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TR-01: Fix media queries (767px instead of 991px) for Position: static on the ul#suggestions
TR-02: Remove list attribute on the Combobox input to avoid confusion with screen readers (long-term solution is through the Header AEM)
TEST CASE 1
1- Open Chrome or Edge developer tools and click the device toolbar (Ctrl + Shift + M)
2- type a few letters in the header search box so that the suggestions appears
3- Resize horizontally and make sure the layout adjust to mobile view at 767px
TEST CASE 2
1- Open the search page with a header search box
2- make sure the 'list' attribute is removed on the input box of the header search box