fix(ARM): exclude ryzenadj if running on non-x86_64 hardware#17
Merged
ShadowApex merged 1 commit intomainfrom Jan 2, 2025
Merged
fix(ARM): exclude ryzenadj if running on non-x86_64 hardware#17ShadowApex merged 1 commit intomainfrom
ShadowApex merged 1 commit intomainfrom
Conversation
pastaq
approved these changes
Jan 2, 2025
Contributor
pastaq
left a comment
pastaq
left a comment
There was a problem hiding this comment.
I'm fine with this change as a future proofing measure for ARM, but PowerStation will be entirely useless on anything but x86_64 right now, so I still think there is value is restricting compiling on ARM for now.
|
🎉 This PR is included in version 0.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds conditional compilation settings to exclude ryzenadj if PowerStation is built for non-x86_64 architectures.