Fix destructor chain for SMTP transports#530
Fix destructor chain for SMTP transports#530peterkelm wants to merge 3 commits intoShardj:masterfrom
Conversation
Zend_Mail_Protocol_Smtp didn't have a destructor whereas its parent class Zend_Mail_Protocol_Abstract has. Yet, in PHO parent destructors have to be called explicitly. This pull request adds a destructor to Zend_Mail_Protocol_Smtp that quits a potential open session and then calls the parent destructor.
|
@peterkelm seems, that tests pointing out to some problem. Could pls check it? |
|
@peterkelm I meant this one, thanks `Fatal error: Uncaught Undefined offset: 1 /home/runner/work/zf1-future/zf1-future/library/Zend/Mail/Protocol/Abstract.php:455 thrown in /home/runner/work/zf1-future/zf1-future/library/Zend/Mail/Protocol/Abstract.php on line 455 |
|
Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/runner/work/zf1-future/zf1-future/library/Zend/Mail/Protocol/Abstract.php on line 461 Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/runner/work/zf1-future/zf1-future/library/Zend/Mail/Protocol/Abstract.php on line 461 Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/runner/work/zf1-future/zf1-future/library/Zend/Mail/Protocol/Abstract.php on line 461 Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/runner/work/zf1-future/zf1-future/library/Zend/Mail/Protocol/Abstract.php on line 461 Undefined array key 1 |
2 participants
Zend_Mail_Protocol_Smtp didn't have a destructor whereas its parent class Zend_Mail_Protocol_Abstract has. Yet, in PHO parent destructors have to be called explicitly.
This pull request adds a destructor to Zend_Mail_Protocol_Smtp that quits a potential open session and then calls the parent destructor.