php 8.5: Replace deprecated methods for SplObjectStorage()#533
Open
sreichel wants to merge 4 commits intoShardj:masterfrom
Open
php 8.5: Replace deprecated methods for SplObjectStorage()#533sreichel wants to merge 4 commits intoShardj:masterfrom
SplObjectStorage()#533sreichel wants to merge 4 commits intoShardj:masterfrom
Conversation
Collaborator
|
imo append() is more appropriate to use, when not setting the index explicitly. What do you think? |
Author
|
Dont get it. There is no |
Collaborator
|
I mixed that with array object, sry |
Collaborator
|
btw, why do we have both failing and successful tests for PHP 8.3-8.5 ? |
Author
|
Error on PHP 8.3 is not new. See https://github.com/Shardj/zf1-future/actions/runs/22686325165/job/65770147967 |
Collaborator
|
@sreichel could you please explain the point of splitting the PHP test, so unsupported version are now both failing and passing? |
Author
|
Thinks its okay that tests for 8.4 and 8.5 fail, as we dont support it. Its only to have it on screen ... The test for 8.3 already failed befor, but showed green for some reason. Try to help asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplObjectStorage::contains()is deprecated since 8.5 #532