fix: unexpected fullscreen on macOS #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically this allows the fullscreen calls to only activate when dwmapi is available, indicating that such environment is Windows. Confirmed as fixed on macOS 12.6 (21G115).
GalvinGao
force-pushed
the
fix/unexpected-fullscreen-macos
branch
from
b21e464 to
44af522
Compare
|
@Shirajuki any progress with the issue of the fullscreen? Thank you |
crousap
approved these changes
Dec 8, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
Fixes #70