Skip to content

Conversation

@BiubiuEhhhh
Copy link

PR Summary:

Why are these changes introduced?

Fixes #0.

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

  • Step 1

Demo links

Checklist

"taxes_included": "Taxes included.",
"duties_included": "Duties included.",
"duties_and_taxes_included": "Duties and taxes included.",
"include_taxes": "Tax included.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Tax included. for key products.product.include_taxes is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@@ -285,21 +244,17 @@
"title": "Your cart",
"caption": "Cart items",
"remove_title": "Remove {{ title }}",
"estimated_total": "Estimated total",
"new_estimated_total": "New estimated total",
"subtotal": "Subtotal",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Subtotal for key sections.cart.subtotal is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

"estimated_total": "Estimated total",
"new_estimated_total": "New estimated total",
"subtotal": "Subtotal",
"new_subtotal": "New subtotal",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value New subtotal for key sections.cart.new_subtotal is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@@ -201,7 +198,7 @@
},
"variant_pills": {
"name": "Variant pills",
"paragraph": "Variant pills are one way of displaying your [product variants](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types/product-pages#variant-picker-block)"
"paragraph": "Variant pills are one way of displaying your product variants. [Learn more](https://help.shopify.com/en/manual/online-store/themes/theme-structure/page-types#variant-picker-block)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • Value for key settings_schema.currency_format.settings.paragraph contains manually formatted currencies: $1.00, USD. Price formatting varies dramatically by region, and there is no single correct format per language, making it not a translation issue, but a localization issue. Note: this is NOT currency conversion, but the way that you display the same currency/price in different regions. Please use a library like ShopifyI18n::Currency instead

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@@ -1,3 +1,12 @@
/*
* ------------------------------------------------------------
* IMPORTANT: The contents of this file are auto-generated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Primary colors for key settings_schema.colors.settings.header__1.content is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

This pull request has been marked as stale due to inactivity for 60 days. If no further activity occurs, it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants