-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Japanbitewongbranch #3832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanbitewongbranch #3832
Conversation
| "taxes_included": "Taxes included.", | ||
| "duties_included": "Duties included.", | ||
| "duties_and_taxes_included": "Duties and taxes included.", | ||
| "include_taxes": "Tax included.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Tax included.for keyproducts.product.include_taxesis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -285,21 +244,17 @@ | |||
| "title": "Your cart", | |||
| "caption": "Cart items", | |||
| "remove_title": "Remove {{ title }}", | |||
| "estimated_total": "Estimated total", | |||
| "new_estimated_total": "New estimated total", | |||
| "subtotal": "Subtotal", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Subtotalfor keysections.cart.subtotalis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "estimated_total": "Estimated total", | ||
| "new_estimated_total": "New estimated total", | ||
| "subtotal": "Subtotal", | ||
| "new_subtotal": "New subtotal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
New subtotalfor keysections.cart.new_subtotalis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -201,7 +198,7 @@ | |||
| }, | |||
| "variant_pills": { | |||
| "name": "Variant pills", | |||
| "paragraph": "Variant pills are one way of displaying your [product variants](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types/product-pages#variant-picker-block)" | |||
| "paragraph": "Variant pills are one way of displaying your product variants. [Learn more](https://help.shopify.com/en/manual/online-store/themes/theme-structure/page-types#variant-picker-block)" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- Value for key
settings_schema.currency_format.settings.paragraphcontains manually formatted currencies:$1.00,USD. Price formatting varies dramatically by region, and there is no single correct format per language, making it not a translation issue, but a localization issue. Note: this is NOT currency conversion, but the way that you display the same currency/price in different regions. Please use a library like ShopifyI18n::Currency instead
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -1,3 +1,12 @@ | |||
| /* | |||
| * ------------------------------------------------------------ | |||
| * IMPORTANT: The contents of this file are auto-generated. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Primary colorsfor keysettings_schema.colors.settings.header__1.contentis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
Baskerville Boldを追加して、what“s in the box"などタイトルに導入しました
|
This pull request has been marked as stale due to inactivity for 60 days. If no further activity occurs, it will be closed in 7 days. |
PR Summary:
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist