Preserve literal semantics in strict2 case/when #2016
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, strict2 case/when used `safe_parse_expression`
to parse when expressions causing `blank`/`empty` to be
treated as string literals (Expression::LITERALS maps 'empty' => ''),
rather than method literals
This caused unexpected behavior:
```
{%- case empty_obj -%}
{%- when empty -%}
previously: doesn't render (empty_obj == '' is false)
now: renders (empty_obj.empty? is true)
{%- endcase -%}
```
This commit instead calls `Condition.parse_expression`
with `safe: true`, which will correctly handle `blank`
and `empty`
dejmedus
commented
Nov 28, 2025
| end | ||
| end | ||
|
|
||
| def test_case_when_empty |
Contributor
Author
There was a problem hiding this comment.
I'm only adding a test for empty as blank requires activesupport in order to render as we expect, however both have parity with lax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
strict2usedsafe_parse_expressionto parsewhenexpressions causingblankandemptyto be treated as string literals (Expression::LITERALS maps 'empty' => ''), rather than method literalsThis caused unexpected behaviour:
{%- case products -%} {%- when empty -%} previously: doesn't render (products == '' is false) now: renders (products.empty? is true) {%- endcase -%}This PR instead calls
Condition.parse_expressionwithsafe: true, which will correctly handleblank/emptyExample