streamline config module 2 #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shourya742
force-pushed
the
2025-07-16-streamline-config-module
branch
2 times, most recently
from
40fed02 to
2a9caf6
Compare
add test for lld opt in and also add thread_local defined state to change opt in targets make the config lld test parameter smoother to work, and have no_llvm_config set even when target_config is not present
Partially reverts commit 40311c4.
See RUST-141600: this test is broken in two ways: 1. This test triggers `-Wincompatible-pointer-types` on GCC 14. 2. This test requires ARMv8.5+ w/ MTE extensions enabled, but GHA CI runner hardware do not have this enabled.
And more broadly only codegen `InstanceKind::Item` using the naked function codegen code. Other instance kinds should follow the normal path.
and use it for naked functions
Signed-off-by: xizheyin <[email protected]>
./x is recommended over running ./x.py directly, and is the more commonly-used invocation of bootstrap in the guide
Nowhere else is this called "Dist check"
That is, calling it an example is misleading
- --depth=1 is more useful for once-off uses, like on ci - .git postfix on github repo url is not needed
Co-authored-by: Boxy <[email protected]>
This updates the rust-version file to fd2eb39.
Shourya742
force-pushed
the
2025-07-16-streamline-config-module
branch
from
2a9caf6 to
c34d1e8
Compare
1. Moves TOML build parsing into a separate module. 2. Corrects the ordering of `apply_*_config` method calls. 3. Moves download logic specific to `toml_config` into its own module. 4. Updates tests to align with the correct behavior.
Shourya742
force-pushed
the
2025-07-16-streamline-config-module
branch
from
fa34727 to
60e2264
Compare
Shourya742
force-pushed
the
2025-07-16-streamline-config-module
branch
from
71b3fd6 to
8b711ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.