Add support to set DUTMaskModeModifier on DUT channels to constellation satellite#98
Open
xaxis-ii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AIDA TLU Constellation satellite currently does not provide a way to set the
DUTMaskModeModifierregister on the AIDA2020 TLU, and by default sets this register to zero. This is inconsistent with the default value loaded by the EUDAQ2 producer (0xFF, enabling the modifier for all channels), and in the latter case the register can be directly written in the EUDAQ config.We have a testbeam/testbench setup (AlVin readout system for ATLAS HGTD/ALTIROC) which we are currently migrating to Constellation, but which relies on being able to raise a DUT busy via the DUTclk signal, and hence needs the DUTMaskModeModifier set for some but not all DUTs. As a result, we need to be able to set this register in the Constellation satellite configuration.
This PR adds the desired functionality as a fourth possible "mode" for a DUT channel - "eudet_with_busy", which enables the
DUTMaskModeModifierfor the given channel by setting the requisite bit (2 ** channel). Since this mode only affects the EUDET mode (according to the manual), I believe it is not necessarily to allow this bit to be modifiable for channels that are not in EUDET mode, hence the decision to add it as an extra mode.Thanks for your time, wishing you a nice start to the week!