Code Style: pre commit #266
Merged
Merged
Conversation
cbespin
reviewed
Apr 21, 2026
cbespin
requested changes
Apr 21, 2026
Comment on lines
-41
to
-42
| self.R_RATIO = np.array([18.85, 14.429, 11.133, 8.656, 6.779, 5.346, 4.245, 3.393, 2.728, 2.207, 1.796, 1.47, 1.209, 1.0, 0.831, 0.694, 0.583, 0.491, 0.416, 0.354, 0.302, 0.259, 0.223, 0.192, 0.167, 0.145, 0.127, 0.111, 0.0975, 0.086, 0.076, 0.0674, 0.0599, 0.0534]) | ||
| self.B_CONST = np.array([3140, 3159, 3176, 3194, 3210, 3226, 3241, 3256, 3270, 3283, 3296, 3308, 3320, 3332, 3343, 3353, 3363, 3373, 3382, 3390, 3399, 3407, 3414, 3422, 3428, 3435, 3441, 3447, 3453, 3458, 3463, 3468, 3473, 3478]) |
Contributor
There was a problem hiding this comment.
This is another occurrence that should be wrapped with magic comment to prevent the line breaks.
Contributor
Author
There was a problem hiding this comment.
We can still think whats better, a exception and a single line or this long array over multiple line. I am fine with both. I think both are not really nicely readable...
Contributor
|
I think some of the remarks solve themselves when the line length is smaller. Not sure if we want to proceed anyway and then make a follow-up reducing the line length. |
cbespin
approved these changes
Apr 22, 2026
Contributor
cbespin
left a comment
cbespin
left a comment
There was a problem hiding this comment.
Nice! Thanks for the work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added and applied pre-commit hooks. The hooks are basically the same as used in obelix1-daq and are also checked in the CI.
The code style hooks consist of:
Isort sorts imports
ruff Checks and fixed code-style. The maximum line length is set to 180.
pre-commit from this package the end-of-file-fixer and trailing-whitespace are used and applied.
This applies of course many changes to the repository but these changes are only style based.
In response to #257.