set temperature instance to 0 instead of 107 - #76
Open
sivu wants to merge 1 commit into
Open
Conversation
…isible to canview, maretron dsm410, and simrad autopilot device view
Member
|
Making the insfance id configurable should be fairly easy. Could you look into it? |
Member
|
@sbender9 is there something magical about 107? |
Member
No. Random. |
Member
|
Of course, changing it now could mess with people's existing installs. |
Author
|
since instances are usually in the range of <10, some devices do not want to understand instance id >100 |
Member
|
I think we just need to make it configurable and default to 107 for existing installs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue that the temperature values sent by signalk were not displayed on nmea displays (Canview, maretron dsm410, simrad autopilot). setting the instance id to 0 solved the issue. Ideally the instance id should be a configuration option in plugin config.