Fix incorrect CMake option name in build-w-opt-can-arg workflow#61
Draft
Copilot wants to merge 2 commits intomark/feat/make-config-options-overridablefrom
Draft
Fix incorrect CMake option name in build-w-opt-can-arg workflow#61Copilot wants to merge 2 commits intomark/feat/make-config-options-overridablefrom
Copilot wants to merge 2 commits intomark/feat/make-config-options-overridablefrom
Conversation
….yml Co-authored-by: SimonCahill <3124521+SimonCahill@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on config options changes
Fix incorrect CMake option name in build-w-opt-can-arg workflow
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build_w_custom_can_argCI job was passing-Disotp_ENABLE_CAN_SEND_ARG=ON(missing thec), so CMake silently ignored the option and the job never actually tested the CAN send arg build configuration.Change
.github/workflows/build-w-opt-can-arg.ymlline 30:-Disotp_ENABLE_CAN_SEND_ARG=ON→-Disotpc_ENABLE_CAN_SEND_ARG=ON, matching the option defined inCMakeLists.txtand already used correctly by thebuild_w_custom_can_arg_enable_eventsjob on line 61.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.