Skip to content

Conversation

@jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Jun 29, 2023

Add bundle name list.

@jhlegarreta
Copy link
Contributor Author

@ljod @zhangfanmark

Add bundle name list.
@jhlegarreta jhlegarreta force-pushed the AddBundleDictionary branch from 6c63691 to 77066b7 Compare July 15, 2023 20:52
@jhlegarreta
Copy link
Contributor Author

Another minor inconsistency is the case used for the IOFF:

  • written as IoFF here.
  • written as IOFF in the bundle files downloaded from zenodo.

We should decide on the case and stick to one.

@jhlegarreta jhlegarreta force-pushed the AddBundleDictionary branch from 77066b7 to 44b84c0 Compare July 16, 2023 16:43
@zhangfanmark zhangfanmark merged commit 1e98e53 into SlicerDMRI:master Aug 3, 2023
@jhlegarreta jhlegarreta deleted the AddBundleDictionary branch August 3, 2023 14:09
@jhlegarreta
Copy link
Contributor Author

Can we discuss about this #123 (comment) ?

@ljod
Copy link
Member

ljod commented Aug 3, 2023

I don't understand what we need to discuss? It should be IOFF all capitals though

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Aug 3, 2023

I don't understand what we need to discuss? It should be IOFF all capitals though

I'm fine with this 👍: just wanted to have a decision on the direction of the changes to be made. Thanks.

@jhlegarreta
Copy link
Contributor Author

I'm fine with this +1: just wanted to have a decision on the direction of the changes to be made. Thanks.

Done in SlicerDMRI/ORG-Atlases#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants