-
Notifications
You must be signed in to change notification settings - Fork 91
Implement experimental input method protocol #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To test:
|
0b32f82
to
9fe9cbd
Compare
Repositioning has been tested now:
Screencast_20250524_202116.webm |
95f4e5a
to
a4c69a5
Compare
} | ||
|
||
pub fn delete_surrounding_text(&self, before_length: u32, after_length: u32) { | ||
// TODO: this has 2 separate behaviours: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that I understand the difference in the protocol. The preedit text is just removed in the case that it is present, and otherwise it works the same, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the preedit is not affected by this. That's actually a mistake, I should have typed "surrounding_text". When the surrounding text is reported, this can count bytes to arrive at the right spot. When it's not reported, the input method has no way to know what it deletes.
40d3b83
to
956b0ed
Compare
Bump. Anyone interested? |
Hi, sorry for the delayed response. Are you planning on depending on https://github.com/Smithay/wayland-rs for the protocol, instead of your repository? I think it otherwise looks good. |
c871405
to
a1fb1ed
Compare
Thank you for reminding me, I lost the notification for a couple days. I updated the dependency now. |
With popup additions: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/407
Missing/untested: repositioning.