Draft: Implement keyboard filtering for input method #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft because it's not verified end-to-end and the protocol is still a proposal.
It adds the methods needed for input methods to filter keyboard events before they reach the text input client, as submitted to wayland-protocols
The idea is: the client requests a keyboard and passes it to the input method to change its purpose.
Currently, it's just a bunch of methods the user calls, but I'm not sure this low-level approach is the best. The bind call could create a keyboard automatically for the current seat. Also, the bind/unbind calls could protect the user from protocol errors by remembering if a keyboard is set and returning Result. Would that be an improvement?