Fix the CI pipeline (#1769)

* Relax clippy warnings and unbreak ci

* clippy: Fix abs_diff warning

* doc: Fix redundant-explicit-link errors

rustdoc::redundant-explicit-link matches more cases in the nightly rust
version. Remove the redundant links that trigger the warning, which is
processed as an error in CI due to `-D warnings` in the rustdoc flags.

The three redundant links all refer to items that are imported into the
current file and therefore do not require explicit, absolute links to
resolve.

---------

Co-authored-by: dcz <[email protected]>
Co-authored-by: Tom Stokes <[email protected]>

Author: 3 people

anvil/src/input_handler.rs

@@ -66,6 +66,8 @@ use smithay::{
 };
 
 impl<BackendData: Backend> AnvilState<BackendData> {
+    // Allow in this method because of existing usage
+    #[allow(clippy::uninlined_format_args)]
     fn process_common_key_action(&mut self, action: KeyAction) {
         match action {
             KeyAction::None => (),

anvil/src/main.rs

@@ -12,6 +12,8 @@ static POSSIBLE_BACKENDS: &[&str] = &[
 static GLOBAL: profiling::tracy_client::ProfiledAllocator<std::alloc::System> =
     profiling::tracy_client::ProfiledAllocator::new(std::alloc::System, 10);
 
+// Allow in this function because of existing usage
+#[allow(clippy::uninlined_format_args)]
 fn main() {
     if let Ok(env_filter) = tracing_subscriber::EnvFilter::try_from_default_env() {
         tracing_subscriber::fmt()

anvil/src/udev.rs

@@ -1,3 +1,5 @@
+// Allow in this module because of existing usage
+#![allow(clippy::uninlined_format_args)]
 use std::{
     collections::hash_map::HashMap,
     io,

src/backend/egl/display.rs

@@ -1042,7 +1042,7 @@ impl EGLBufferReader {
     /// Try to receive [`EGLBuffer`] from a given [`WlBuffer`].
     ///
     /// In case the buffer is not managed by EGL (but e.g. the [`wayland::shm` module](crate::wayland::shm))
-    /// a [`BufferAccessError::NotManaged`](crate::backend::egl::BufferAccessError::NotManaged) is returned.
+    /// a [`BufferAccessError::NotManaged`] is returned.
     #[profiling::function]
     pub fn egl_buffer_contents(
         &self,

src/backend/mod.rs

@@ -1,3 +1,5 @@
+// Allow in this module because of existing usage
+#![allow(clippy::uninlined_format_args)]
 //! Backend (rendering/input) helpers
 //!
 //! This module provides helpers for interaction with the operating system.

src/input/keyboard/mod.rs

@@ -942,7 +942,7 @@ impl<D: SeatHandler + 'static> KeyboardHandle<D> {
     /// [`FilterResult::Intercept`] a value can be passed to be returned by the whole function.
     /// This mechanism can be used to implement compositor-level key bindings for example.
     ///
-    /// The module [`keysyms`](crate::input::keyboard::keysyms) exposes definitions of all possible keysyms
+    /// The module [`keysyms`] exposes definitions of all possible keysyms
     /// to be compared against. This includes non-character keysyms, such as XF86 special keys.
     #[instrument(level = "trace", parent = &self.arc.span, skip(self, data, filter))]
     pub fn input<T, F>(

src/utils/serial.rs

@@ -22,11 +22,7 @@ impl Eq for Serial {}
 impl PartialOrd for Serial {
     #[inline]
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        let distance = if self.0 > other.0 {
-            self.0 - other.0
-        } else {
-            other.0 - self.0
-        };
+        let distance = self.0.abs_diff(other.0);
         if distance < u32::MAX / 2 {
             self.0.partial_cmp(&other.0)
         } else {

src/wayland/mod.rs

@@ -1,3 +1,5 @@
+// Allow in this module because of existing usage
+#![allow(clippy::uninlined_format_args)]
 //! Protocol-related utilities
 //!
 //! This module contains several handlers to manage the Wayland protocol

src/wayland/selection/data_device/mod.rs

@@ -259,7 +259,7 @@ where
 /// You need to provide the available mime types for this selection.
 ///
 /// Whenever a client requests to read the selection, your callback will
-/// receive a [`SelectionHandler::send_selection`](crate::wayland::selection::SelectionHandler::send_selection) event.
+/// receive a [`SelectionHandler::send_selection`] event.
 #[instrument(name = "wayland_data_device", level = "debug", skip(dh, seat, user_data), fields(seat = seat.name()))]
 pub fn set_data_device_selection<D>(
     dh: &DisplayHandle,

src/xwayland/mod.rs

@@ -1,3 +1,5 @@
+// Allow in this module because of existing usage
+#![allow(clippy::uninlined_format_args)]
 //! XWayland utilities
 //!
 //! This module contains helpers to manage XWayland from your compositor, in order