Make has_modifier() return true for linear modifiers
#1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`has_modifier()` is used in two places. One has a special case for linear modifiers (which could handled specially regardless of what `has_modifier()` returns. The other use doesn't handle linear in any special way, and is probably incorrect, though drivers may tend to work with it anyway. Implicit modifiers are not in general linear, so semantically this didn't make much sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has_modifier()is used in two places. One has a special case for linear modifiers (which could handled specially regardless of whathas_modifier()returns. The other use doesn't handle linear in any special way, and is probably incorrect, though drivers may tend to work with it anyway.Implicit modifiers are not in general linear, so semantically this didn't make much sense.
Leaving as a draft, since I'm not actually sure what this breaks or fixes in practice. There may be a reason it was done this way.