Add FilePicker polyglot widget#14
Merged
Merged
Conversation
Cross-platform file picker using <custom-view> with native implementations for Android (ACTION_GET_CONTENT), iOS (UIDocumentPickerViewController), macOS (NSOpenPanel), and web (<input type="file">). Supports onSelect callback, allowMultiple, and MIME type filtering via accept prop. Includes unit tests and playground catalog entry. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Semgrep found 7
This literal might contain a Snapchat internal reference that should not be committed to open-source repositories. Fix: Please replace / remove the string to avoid committing it to open-source repositories. |
Collaborator
|
🐸🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilePickerwidget with native implementations for all four platforms: Android (ACTION_GET_CONTENT), iOS (UIDocumentPickerViewController), macOS (NSOpenPanel), and web (<input type="file">)onSelectcallback,allowMultiple, and MIME type filtering viaacceptpropFilePickerTest.ts) and a playground catalog entry inWidgetsCatalogFiles
widgets/src/components/pickers/FilePicker.tsx<custom-view>wrapperwidgets/android/ValdiFilePicker.ktwidgets/android/ValdiFilePickerAttributesBinder.kt@RegisterAttributesBinder)widgets/ios/SCWidgetsFilePicker.h/.mUIDocumentPickerViewControllerwidgets/macos/SCWidgetsMacOSFilePicker.h/.mNSOpenPanelwidgets/web/src/WidgetsWeb.tswidgets/BUILD.bazelUniformTypeIdentifiersto iOS/macOSsdk_frameworkswidgets/test/components/pickers/FilePickerTest.tsplayground/src/WidgetsCatalog.tsxTest plan
bazel_web_serve.sh→ Widgets Catalog → FilePicker sectionbazel test //valdi_modules/widgets:widgets_test🤖 Generated with Claude Code