fix(Base64ImageInput): component uploads contents instead of a data: url #1548
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Bug fix
Current Behavior
The Base64ImageInput component doesn't upload a base64-encoded contents of the selected image - as name would suggest - but rather just contents of the file, as a string.
New Behavior
The Base64ImageInput actually reads the file into a
data:url, and passes that on into the data structure, as designed.Testing
Affected areas
This PR affects the JSON-Schema forms components.
Time Frame
Other Information
Status