feat(sidebar): in-flight loading state for archive and project delete#255
Open
sidimed-bahan wants to merge 2 commits into
Open
feat(sidebar): in-flight loading state for archive and project delete#255sidimed-bahan wants to merge 2 commits into
sidimed-bahan wants to merge 2 commits into
Conversation
added 2 commits
May 19, 2026 16:33
- Project rows show a spinner avatar + "Deleting…" subtitle while delete is in-flight, with pointer-events disabled to prevent re-clicks - Track deleting projects in a new signal so the UI can react to delete latency - Task rows show "Archiving…" subtitle while isTaskArchiving(id) is true Adjacent infra to unblock the pre-commit hook: - scripts/check.sh strips inherited GIT_* env vars before running tests, so cargo tests that shell out to `git init` in tempdirs no longer re-init the host worktree's gitdir (was corrupting the index during pre-commit) - Switch two descending `sort_by` calls to `sort_by_key(|x| Reverse(x.field))` in mcp.rs and resource_monitor.rs to satisfy the newly-promoted clippy::unnecessary_sort_by lint Related to #150
…g task visible Run the destroy hook inline so archive_task does not return until the worktree hook finishes and the last commit message is persisted. Preserve in-store task order across loadTasks so an in-flight archived task does not jump position, and keep it in the active list while archiving so the loading row stays put.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointer-events-noneto prevent re-clicks. A newdeletingProjectssignal insrc/store/projects.tstracks the in-flight set viaaddDeleting/removeDeletingaround theipc.deleteProject(id)call in atry/finally.isTaskArchiving(id)is true.Adjacent infra (needed to land this safely)
scripts/check.shstrips inheritedGIT_DIR,GIT_INDEX_FILE,GIT_WORK_TREE, andGIT_AUTHOR_*/GIT_COMMITTER_*env vars before running tests. Without this, Rust tests (ipc::tests::git_check_ignore_matching_detects_ignored_paths, all fivegithub_remote::tests::*tests) shell out togit initin tempdirs and end up re-initializing the host worktree's gitdir, corrupting its index and aborting the commit.sort_bycalls (inmcp.rsandresource_monitor.rs) switched tosort_by_key(|x| std::cmp::Reverse(x.field))to satisfy the newly-promoted `clippy::unnecessary_sort_by` lint that's now blocking `cargo clippy -- -D warnings`.Related to #150 — partial fix: the sidebar loading affordance is in place, but the archive button itself in `GitActions` still unmounts the moment archive starts (since the optimistic `archived=true` filter hides the task), so the in-button spinner from issue #150 is a separate follow-up.
Test plan