Skip to content

fix: remove ag_catalog prefix from to_bm25query#25

Merged
Kaiohz merged 1 commit into
mainfrom
fix/bm25-search-path-2
Apr 26, 2026
Merged

fix: remove ag_catalog prefix from to_bm25query#25
Kaiohz merged 1 commit into
mainfrom
fix/bm25-search-path-2

Conversation

@Kaiohz
Copy link
Copy Markdown
Collaborator

@Kaiohz Kaiohz commented Apr 26, 2026

Closes the BM25 search regression on K3s.

Problem
Commit dc06953 added an prefix to inside . This works when is installed in the schema, but the production Dockerfile.db now creates BEFORE , so the extension is installed in .

Changes

  • Reverts the prefix in BM25 search queries.
  • Restores the same SQL behaviour as the local Docker Compose stack.

Verification

  • Local compose (bricks-db) already does before , so resolves in .
  • K3s cluster (with the new postgres custom image) has the same extension order.

After merge, the CD will build & push the new image and update the flux deployment.

Copy link
Copy Markdown
Collaborator Author

@Kaiohz Kaiohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Code Review

✅ Changements validés

Fix minimal et ciblé - retrait du préfixe ag_catalog. pour laisser PostgreSQL résoudre to_bm25query() via le search_path.

Pourquoi c'est correct :

  • L'extension pg_search sera trouvée peu importe son schéma d'installation (public ou ag_catalog)
  • Comportement cohérent entre docker-compose local et K3s

Contexte bien documenté : Le commit dc06953 avait introduit le préfixe pour un cas spécifique, mais le nouvel ordre de création dans le Dockerfile.db change la donne.

⚠️ Suggestion d'amélioration

Tests manquants (non-bloquant) :

  • Pas de test automatisé pour valider le comportement BM25
  • Suggestion : ajouter un test d'intégration BM25 pour éviter les régressions futures

📊 Score de qualité : 8/10

Fix propre, bien documenté. Manque des tests mais le fix est valide.

Recommandation : ✅ APPROVE

@Kaiohz Kaiohz merged commit e6cb6a5 into main Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant