fix: remove ag_catalog prefix from to_bm25query#25
Merged
Conversation
…-compose behavior
Kaiohz
commented
Apr 26, 2026
Collaborator
Author
Kaiohz
left a comment
There was a problem hiding this comment.
🔍 Code Review
✅ Changements validés
Fix minimal et ciblé - retrait du préfixe ag_catalog. pour laisser PostgreSQL résoudre to_bm25query() via le search_path.
Pourquoi c'est correct :
- L'extension
pg_searchsera trouvée peu importe son schéma d'installation (public ou ag_catalog) - Comportement cohérent entre docker-compose local et K3s
Contexte bien documenté : Le commit dc06953 avait introduit le préfixe pour un cas spécifique, mais le nouvel ordre de création dans le Dockerfile.db change la donne.
⚠️ Suggestion d'amélioration
Tests manquants (non-bloquant) :
- Pas de test automatisé pour valider le comportement BM25
- Suggestion : ajouter un test d'intégration BM25 pour éviter les régressions futures
📊 Score de qualité : 8/10
Fix propre, bien documenté. Manque des tests mais le fix est valide.
Recommandation : ✅ APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the BM25 search regression on K3s.
Problem
Commit dc06953 added an prefix to inside . This works when is installed in the schema, but the production Dockerfile.db now creates BEFORE , so the extension is installed in .
Changes
Verification
After merge, the CD will build & push the new image and update the flux deployment.