test(e2e): seed registration enabled in 37-disable-registration#802
Open
test(e2e): seed registration enabled in 37-disable-registration#802
Conversation
The "Registration when enabled (default)" tests assumed the preview DB started in the default enabled state, but the shared preview environment persists state across runs. If a prior run died mid-suite before its `finally` re-enabled registration, the defaults-assuming tests failed permanently. Add a `beforeAll` that explicitly enables registration. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforeAllto the "Registration when enabled (default)" describe block that explicitly POSTsregistration.enabled: trueto/admin/plugins/core-auth/settingsbefore the default-assuming tests run.disabledstate if a prior test run died mid-suite before itsfinallycleanup re-enabled registration.Why
Observed on the post-release doc commit (
721108b) —PR Testsfailed becausecurl -I /auth/registerreturned 302 to/auth/login?error=Registration%20is%20currently%20disabled. The "when enabled" tests had no setup and relied on default state that was no longer true on the shared preview.Test plan
37-disable-registration.spec.tsRegistration when enabled (default)tests pass🤖 Generated with Claude Code