Fix rubocop offenses

[beengine]

Please ensure your pull request includes the following:

• Description of changes
• Changes have related RSpec tests that ensure functionality does not break

This PR relates to the issue #396 and partially covers it.

Summary of Changes

Configuration Updates (.rubocop.yml)

• Added exclusions for Lint/ConstantDefinitionInBlock in spec files (test-specific pattern)
• Added exclusions for Naming/PredicateMethod in lib and spec (adapter pattern compatibility)

Code Style Improvements

Hash & Alignment:

• Fixed hash key alignments across multiple files
• Improved indentation consistency

String & Argument Simplification:

• Removed redundant flatten calls on already-flat arrays (bcrypt.rb, spec files)
• Changed join('') to join (empty string is default)
• Simplified proc { |r| r.email } to :email in validations

Conditional Logic:

• Fixed nested conditionals (Style/SoleNestedConditional) in:
  • brute_force_protection.rb - Combined conditions for unlock check
  • user_activation.rb - Combined conditions for activation state check
• Fixed if/unless modifier usage for single-line conditionals

Method Improvements:

• Replaced unpack('m').first with unpack1('m') for better performance
• Used anonymous block forwarding where appropriate
• Improved symbol proc usage (&:method_name)

Provider URL Refactoring:

• Refactored provider_url method in controller_oauth2_spec.rb for readability:
  • Extracted common config and redirect_uri variables
  • Split long URLs across multiple lines
  • Improved maintainability for OAuth provider URL construction

Removed Redundancies

• Removed redundant constant base references (::)
• Removed redundant cop disable directives
• Removed redundant parentheses in conditionals
• Fixed ambiguous operator precedence warnings

Linting Fixes

• Fixed Lint/UnusedBlockArgument - Used underscore prefix for unused block args
• Fixed Lint/SendWithMixinArgument - Corrected mixin inclusion patterns
• Fixed Lint/AmbiguousOperatorPrecedence - Added clarity to complex expressions

Empty Line Management

• Added/removed empty lines for better code organization
• Improved visual separation of logical code blocks

Files with Significant Changes

Library Files:

• lib/sorcery/crypto_providers/bcrypt.rb - Removed redundant flatten
• lib/sorcery/crypto_providers/aes256.rb - Used unpack1 for efficiency
• lib/sorcery/model/submodules/brute_force_protection.rb - Simplified nested conditionals
• lib/sorcery/model/submodules/user_activation.rb - Simplified nested conditionals

Spec Files:

• spec/controllers/controller_oauth2_spec.rb - Major refactor of provider_url method
• spec/shared_examples/user_shared_examples.rb - Multiple style fixes
• spec/sorcery_crypto_providers_spec.rb - Removed redundant flatten calls

.rubocop_todo.yml Cleanup

Removed violations for the following cops (all now fixed):

• Style/SoleNestedConditional (4 offenses)
• Style/UnpackFirst (1 offense)
• Style/RedundantArrayFlatten (5 offenses)
• Style/SymbolProc (1 offense)
• Hash alignment offenses
• Empty line offenses
• And many more...

[Copilot]

Pull Request Overview

This PR fixes RuboCop offenses across the codebase, focusing on code style improvements, redundancy removal, and conditional logic simplification while maintaining backward compatibility.

Key changes:

• Removed redundant constant base references (::) throughout spec and lib files
• Simplified nested conditionals by combining conditions where appropriate
• Applied Ruby idioms (e.g., unpack1 instead of unpack.first, anonymous block forwarding)

Reviewed Changes

Copilot reviewed 46 out of 55 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
spec/spec_helper.rb	Removed redundant :: prefix from constant references
spec/sorcery_crypto_providers_spec.rb	Removed redundant flatten calls and changed comment style to uppercase NOTE
spec/shared_examples/*.rb	Removed :: prefixes, updated block argument naming, changed expect block delimiters
spec/rails_app/config/*.rb	Converted multi-line conditionals to single-line modifiers
spec/providers/vk_spec.rb	Fixed redundant regex escape in URL pattern
spec/controllers/controller_oauth2_spec.rb	Refactored provider_url method for better readability, removed :: prefixes, updated string quotes
lib/sorcery/test_helpers/*.rb	Applied anonymous block forwarding, updated hash syntax
lib/sorcery/providers/*.rb	Simplified authorize_url calls, fixed operator precedence, updated regex usage
lib/sorcery/model/*.rb	Simplified nested conditionals, applied anonymous block forwarding
lib/sorcery/crypto_providers/*.rb	Removed redundant flatten calls, added empty lines after include
lib/sorcery/controller/*.rb	Simplified conditionals, applied anonymous block forwarding, reorganized attr_accessor declarations
lib/sorcery/adapters/*.rb	Updated hash syntax, applied anonymous block forwarding, simplified conditionals
lib/sorcery/engine.rb	Replaced send(:include) with direct include call
lib/generators/sorcery/*.rb	Fixed redundant parentheses, updated regex usage
.rubocop_todo.yml	Removed fixed offense entries
.rubocop.yml	Added exclusions for Naming/PredicateMethod and Lint/ConstantDefinitionInBlock

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[willnet]

Thank you for your contribution. It’s easier to review if each cop fix is a separate commit, so if possible, please create commits in smaller chunks.

The failing CI should pass once you rebase onto the current master.